bitmotor/unirest-php
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
262 Commits 1 Branch 24 Tags
5d304c6f6c0a6a75cdf4149005bd19479d3e6b1e
Commit Graph
262 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
İrfan EvrensandAhmad Nassri 5d304c6f6c improved syntax and some codes. (#108) 
* improved syntax and some codes.

* back to original for Body.php
v3.0.3 		2016-05-31 12:59:14 -04:00
Ahmad Nassri 53656bf519 Merge pull request #105 from voodoodrul/patch-2 
Don't use CURLOPT_CUSTOMREQUEST for POSTs
v3.0.2 		2016-04-29 19:54:44 -04:00
Ahmad Nassri 889ca14f5f Merge pull request #106 from Lozzano/master 
Fixing current version in README.
 2016-04-25 10:03:29 -04:00
André Valentin 45274fd536 Fixing current version in README. 
The current version wasn't showed as the one people should add in their composer files. Updated from 2.* to 3.*.
 2016-04-25 15:02:42 +02:00
Jesse Skrivseth a3446f6d99 Update Request.php 
Remove curl_setopt(self::$handle, CURLOPT_POSTREDIR, 3);  in favor of the caller being well-behaved and setting this option as needed
 2016-04-19 23:05:11 -06:00
Jesse Skrivseth e9ea4dbee2 Don't use CURLOPT_CUSTOMREQUEST for POSTs 
I think the current usage of CURLOPT_CUSTOMREQUEST is wrong. As far as I can tell CURLOPT_CUSTOMREQUEST = Method::POST is not the same thing as CURLOPT_POST = true. 

I struggled for hours with POSTed data not being accepted by IIS. First IIS threw an HTTP 411 due to curl not sending a Content-Length header. That is solved by replacing CURLOPT_CUSTOMREQUEST with CURLOPT_POST in the case of actual POSTs. Also, IIS in my case returns an HTTP 301 redirect, which I need Unirest to follow, so I set the CURLOPT_POSTREDIR = 3 in order to let the POST follow on redirect via 301 or 302. 

Notice this: https://curl.haxx.se/libcurl/c/CURLOPT_CUSTOMREQUEST.html - "Many people have wrongly used this option to replace the entire request with their own, including multiple headers and POST contents. While that might work in many cases, it will cause libcurl to send invalid requests and it could possibly confuse the remote server badly. Use CURLOPT_POST and CURLOPT_POSTFIELDS to set POST data. Use CURLOPT_HTTPHEADER to replace or extend the set of headers sent by libcurl. Use CURLOPT_HTTP_VERSION to change HTTP version."

In any case, I know that the CURLOPT_POSTREDIR option probably shouldn't go here and should be client configurable, but I can't find a good place for it. It would be nice to have one-shot $curlOpts passed in with the send method, or curlOpts() that otherwise live for only one curl_exec().
 2016-04-19 22:49:27 -06:00
Colin Hutchinson d71cd15d4a Merge pull request #102 from xcopy/master 
Typofix
 2016-04-14 08:33:01 -04:00
Kairat Jenishev 2d0cd4c8d9 Typofix 2016-04-14 17:01:32 +06:00
Ahmad Nassri c01f685e3b Merge pull request #98 from RusinovIG/master 
Issue with priority of headers
v3.0.1 		2016-03-23 00:18:08 -04:00
Igor Rusinov 28080c975c Fixedissue with priority of headers 2016-03-20 20:53:52 +03:00
Ahmad Nassri 2bedcf05ac docs(readme): fix content-types in labels [ci skip] v3.0.0 2016-02-24 23:27:05 -05:00
Ahmad Nassri b6328f270f chore(travis): fix namespacing issues 2016-02-24 23:23:54 -05:00
Ahmad Nassri 1e86cc751f chore(travis): move to container mode in travis 2016-02-24 23:13:33 -05:00
Ahmad Nassri 825cee7dc7 chore(travis): fix namespacing issues 2016-02-24 23:12:45 -05:00
Ahmad Nassri eb470e929c chore(travis): test on all current PHP versions 2016-02-24 23:02:39 -05:00
Ahmad Nassri d23cdc5593 refactor(request): request body management is now externalized to helper methods 2016-02-24 23:01:21 -05:00
Ahmad Nassri 0f3a22d63e feat(json): json pecl extension may be available all the time 2016-02-24 22:07:25 -05:00
Ahmad Nassri f7f13bd940 Merge pull request #91 from Furgas/fix-curlfile 
Fix creating CURLFile
 2016-02-16 14:25:22 -05:00
Tomasz Sawicki d950a88257 Fix creating CURLFile 2016-02-16 19:54:45 +01:00
Ahmad Nassri 73c2d90323 Merge pull request #90 from Furgas/fix-phpdoc 
Fix PHPDoc
v2.6.6 		2016-02-16 11:45:52 -05:00
Tomasz Sawicki d0fc831a00 Fix PHPDoc 2016-02-16 10:49:00 +01:00
Ahmad Nassri 4a480b156b Merge pull request #89 from RusinovIG/master 
Fixed setting of default headers array
v2.6.5 		2016-01-20 14:41:35 -05:00
Igor Rusinov ca6a3b1daf Fixed setting of default headers array 2016-01-18 23:24:14 +03:00
Ahmad Nassri da71f063cf Merge pull request #88 from frankdee/master 
improved solution to override cURL options …
v2.6.4 		2015-12-15 17:22:11 -05:00
frankdee be5ee63ad1 shortened cURL options array merging 2015-12-14 19:17:31 +01:00
frankdee 32334a6bfa improved solution to override cURL options, that preserves the right indices in cURL option arrays 
(Note: PHP seems to not override all options when calling 'curl_setopt_array(..)' several times after another)
 2015-12-14 13:55:49 +01:00
Ahmad Nassri e11c54d29c Merge pull request #86 from Mashape/curlopts-override-fix 
allow to override curlopts
v2.6.3 		2015-12-11 18:41:55 -05:00
Ahmad Nassri a3312a0ecd allow to override curlopts 2015-12-11 18:38:09 -05:00
Augusto Marietti fde6f41733 Update README.md 2015-10-16 19:40:03 -07:00
Ahmad Nassri 75258a2024 Merge pull request #83 from mircobabini/patch-1 
fix composer command
 2015-09-03 11:12:21 -04:00
Mirco Babini b330685820 fix composer command 2015-09-03 15:39:52 +02:00
Augusto Marietti 2f7aea9f63 Update README.md 2015-07-28 00:27:17 -07:00
Ahmad Nassri f04b42e75e Merge pull request #81 from gabrielzerbib/master 
phpdoc return type for ::post
v2.6.2 		2015-07-27 12:17:35 -07:00
Gabriel Zerbib 32c1a9fef0 Merge branch 'master' of https://github.com/gabrielzerbib/unirest-php 2015-07-27 22:07:56 +03:00
Gabriel 2b5b349036 phpdoc return type for ::post 2015-07-27 22:07:05 +03:00
Gabriel 1017f14ef5 phpdoc return type for ::post 2015-07-27 14:57:24 +03:00
Ahmad Nassri 99c6975f23 Merge pull request #79 from voodoodrul/patch-1 
Allow disabling of CURLOPT_SSL_VERIFYHOST
2.6.1 		2015-06-08 13:29:31 -04:00
Jesse Skrivseth f257217434 Fix CURLOPT_SSL_VERIFYHOST issue 
libcurl's CURLOPT_SSL_VERIFYHOST option accepts only values 0 and 2. This fix is fail-secure in that SSL host verification will be enabled regardless of what a caller passes to Request::verifyHost($bool) unless $bool === false.
 2015-06-08 08:50:58 -06:00
Jesse Skrivseth c9c0a85250 Allow disabling of CURLOPT_SSL_VERIFYHOST 
Useful when the SSL cert has an invalid or non-resolvable hostname
 2015-06-05 19:50:11 -06:00
Ahmad Nassri 3e375515fe Update README.md 2015-04-22 11:40:44 -04:00
Ahmad Nassri b6fb76ce12 oops, forgot notifications 2015-04-09 12:29:10 -04:00
Ahmad Nassri 5926846300 events are required for gitter hook? 2015-04-09 12:02:12 -04:00
Ahmad Nassri feae18f980 add gitter webhook 2015-04-09 11:22:15 -04:00
Ahmad Nassri b0df287d64 README fix v2.6.0 2015-04-08 17:36:02 -04:00
Ahmad Nassri 4221ee5138 setting custom curl options 
- `Unirest\Request::curlOpt()`
- `Unirest\Request::curlOpts()`
- `Unirest\Request::clearCurlOpts()`

fixes #78
 2015-04-08 17:35:14 -04:00
Ahmad Nassri ec5828c8aa Merge pull request #77 from cristianp6/master 
Fixed "Undefined variable: ch" and add cookie string support
v2.5.0 		2015-04-03 13:08:41 -04:00
cristianp6 0293eb258c Add cookie string support, aka CURLOPT_COOKIE 2015-04-03 12:04:49 +02:00
cristianp6 a1ed45be55 Fixed "Notice: Undefined variable: ch" on curl_setopt cookieFile 2015-04-03 11:16:17 +02:00
Ahmad Nassri 8da79e7898 updating README and fixing typo v2.4.0 2015-04-02 14:22:32 -04:00
Ahmad Nassri 217b436124 manually applying PR by @daydiff due to complex merge issues, closes #67 2015-04-02 14:11:23 -04:00